Repository navigation
Re-pin the vendored Spec to c8f6852 - #230
Merged
Merged
Conversation
MorphoBricks-Spec PR 15: the optional boolean `rgb_support` key of a brick's provider manifest (RC1) and one A_SCOPE_INCOMPLETE rule for a channel or mask absent from all images or from some (SI1). Text only; fixtures and the reference validator are unchanged. PIN.toml, the copied experiment-v1.md and fixtures README, SPEC_COMMIT and docs/conformance.md updated as in #208 and #216. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Scma6W3LC11s3qjXHZuGDm
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed in the Spec (MorphoBricks-Spec PR 15,
2975e0etoc8f6852)Text only; no fixture and no reference validator change (only
fixtures/README.mddiffers).experiment-v1.md4.4b: a brick that publishes a provider manifest declares RGB support with the optional top-level boolean keyrgb_support.trueis support;falseand an absent key are unsupported; a non-boolean is a manifest error, never read astrue. The key gives RGB no meaning and does not change a description. TheA_RGB_NOT_SUPPORTEDrefusal applies to a described run only.A_SCOPE_INCOMPLETErule for a channel or mask absent from part of the requested scope or from all of it; the refusal names it and says "present in k of n acquisitions" (kmay be 0).Files (done as in #208 and #216)
tests/spec_fixtures/PIN.toml: commitc8f68526c08633526395ca0180fd6bd1a182fc84,fixtures_tree87d097408e5b794f31f902ec30f2a17dd941a1bd, blob ofdocs/experiment-v1.mde3d311b63e7ec7d2128a307822339806a10785dd(tools/audit/refval.pyblobde5a2cd...unchanged).tests/spec_fixtures/docs/experiment-v1.md,tests/spec_fixtures/fixtures/README.md(taken from a fresh clone at the pinned commit; the other fixtures andrefval.pyare byte-identical).SPEC_COMMITinsrc/morphobricks_preprocessing/draft_format.py, anddocs/conformance.md(vendoredexperiment-v1.mdatc8f6852).CHANGELOG.mdentry.Consequence for drafts (#224)
SPEC_COMMITchanges, so a draft file saved under the previous pin is refused at resume and bypublish_draftwithDraftFileErrorcodespec_commit_mismatch. The publishedmorphobricks.tomlis untouched; the user starts a fresh draft from the folders and re-gives the confirmations. Merging this invalidates every draft in progress.Reader changes implied by the new text
None implemented here, and none needed: RC1 is a key of the bricks' provider manifests and SI1 is brick behaviour (
ChannelNotFoundErroralready carriesA_SCOPE_INCOMPLETE, #229). Not done here, for the bricks: read and validatergb_supportin each brick's manifest, refuseA_RGB_NOT_SUPPORTEDon described runs only, and word the SI1 message as "present in k of n acquisitions" (check that the currentChannelNotFoundErrormessage does; this PR did not change it).Results
tests/test_spec_pin.pyand the cross-check module: 219 passed).python tools/check.py: ruff check and format clean, 4634 passed, 4 skipped (the 4 skips are the pre-existing file-system-case and file-mode tests), code rules clean.Expect CHANGELOG conflicts with open PR #217 and the notebook PR; keep both sides when merging main.
Generated by Claude Code